pickle_loads(): Handle empty memoryview #4595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasiben
approved these changes
Mar 17, 2021
Member
|
3.9 failed -- I kicked the CI and if tests pass I'll merge |
Member
|
The 3.8 test failed this time on:
https://github.com/dask/distributed/pull/4595/checks?check_run_id=2131423616#step:10:1704 |
jakirkham
approved these changes
Mar 18, 2021
Member
|
Thanks Mads! 😄 |
Member
|
Yeah I saw a couple sporadic fails, but they didn't appear to be consistent on platform, Python version, or even which test. None of them appeared related to the change. We have several known ones here ( https://github.com/dask/distributed/issues?q=is%3Aissue+is%3Aopen+label%3A%22flaky+test%22 ). This one sounds new, but don't see how it would be related to this change and didn't seem to pop back up. We can keep an eye out for it though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4594
black distributed/flake8 distributed