Let servers close faster if there are no active handlers#4805
Merged
Let servers close faster if there are no active handlers#4805
Conversation
Member
Author
|
osx failure again #4766 |
345d1d9 to
9aab738
Compare
jrbourbeau
approved these changes
May 26, 2021
9aab738 to
e300e42
Compare
douglasdavis
pushed a commit
to douglasdavis/distributed
that referenced
this pull request
May 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another marginal fix for test runtimes.
we have a hard coded grace period allowing incoming connections to finish on their own in case we want to close before we pull out the hammer.
A few things are a bit off here
This hard coded wait period causes effectively every single
await Worker.close()to block for a second if the worker has had any incoming connections before. For some tests this makes the difference between subsecond and multi second runtime.I think we should kick this waiting time out completely but either way, this give the entire process tests and a bit of a bigger purpose than before.