Fix _graph_to_futures bug for futures-based dependencies#4178
Merged
jrbourbeau merged 4 commits intodask:masterfrom Oct 23, 2020
Merged
Fix _graph_to_futures bug for futures-based dependencies#4178jrbourbeau merged 4 commits intodask:masterfrom
jrbourbeau merged 4 commits intodask:masterfrom
Conversation
Member
Author
|
Anyone with distributed knowledge know if the windows CI failure is likely to be related to these changes? (maybe @quasiben) |
Member
|
I think the failure is unrelated but I kicked the CI hoping that a restart comes back green |
madsbk
approved these changes
Oct 23, 2020
Contributor
madsbk
left a comment
There was a problem hiding this comment.
LGTM, simple fix and the regression test is very helpful when developing the permanent solution.
Contributor
Member
Author
|
Judging by @martindurant 's comment, it looks like we should merge this temporary fix, and then try to modify tuple usage in streamz before adding any follow-up changes that may (or may not) dissallow their current usage. |
jrbourbeau
approved these changes
Oct 23, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4177
depends on dask#6761After an offline discussion with @madsbk and @jrbourbeau , I decided to revise this PR into a "standalone" fix (that does not depend on changes in dask/dask). The new fix will address the problem, but will also materialize the underlying graph in cases with futures. Therefore, this should be viewed as a temporary change, that will (hopefully) be replaced with ongoing HLG work relatively soon.