[WIP] Add optional pass_key argument to map_tasks#6761
Closed
rjzamora wants to merge 2 commits intodask:masterfrom
Closed
[WIP] Add optional pass_key argument to map_tasks#6761rjzamora wants to merge 2 commits intodask:masterfrom
rjzamora wants to merge 2 commits intodask:masterfrom
Conversation
madsbk
suggested changes
Oct 22, 2020
Contributor
madsbk
left a comment
There was a problem hiding this comment.
I think this is a great feature @rjzamora but I am a bit concerned with the Blockwise implementation of the key (see my comment).
But if we can get this to work, let's make the key argument mandatory. All the map_tasks() implementations need to support it anyways.
| if input_indices is None: # A literal | ||
| new_indices.append((func([key]), None)) | ||
| if pass_key: | ||
| new_indices.append((func([key], key), None)) |
Contributor
There was a problem hiding this comment.
I don't think this is strictly correct. key here is a literal and not a graph key. See
Lines 380 to 382 in 97c2f06
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
Member
|
Is it safe to close this PR since we ended up going another direction in dask/distributed#4178? |
Member
Author
|
Yeah - It is unlikely we will need this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
pass_keyargument tomap_tasks. This enables a simple fix to distributed#4177, because it allows themap_tasksutility to be used to collect proper task-future dependencies.black dask/flake8 dask