Update to support Sphinx Book Theme >=1 and Sphinx >=5#93
Conversation
|
Testing this out in dask/dask#12093 |
|
The pre-commit action needed bumping because the service it was calling no longer existed. |
jrbourbeau
left a comment
There was a problem hiding this comment.
Thank you for working on this @jacobtomlinson! Really looking forward to removing these pins
I just took this PR (and the corresponding dask/dask PR dask/dask#12093) for a spin. I'm not seeing what you posted in your screenshot. Here's what I'm seeing locally when I install these PRs in a fresh environment
which is in line with the docs preview over in the dask/dask PR https://dask--12093.org.readthedocs.build/en/12093/
Any thoughts on what's different for you locally? Obviously yours looks better : )
|
Ahhh dark mode! I thought I'd successfully disabled dark mode to keep things simple, but you must have something set in your browser that's turning it on. As you can tell I didn't bother correctly styling dark mode. Let me see how much work it would be to support dark mode. |
|
Ok dark mode should be working now. I've poked both CI's so the previews should show correctly. 
|
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson! Overall this looks great -- just a few small questions
| - name: Build dask-sphinx-theme dist | ||
| run: | | ||
| python -m pip install wheel twine | ||
| python setup.py sdist bdist_wheel |
There was a problem hiding this comment.
@jacobtomlinson I think this line needs to be updated too. We're seeing
python: can't open file '/home/runner/work/dask-sphinx-theme/dask-sphinx-theme/setup.py': [Errno 2] No such file or directory
when this step is run on main
https://github.com/dask/dask-sphinx-theme/actions/runs/18470367546/job/52622468007
sphinx-book-themeversion pinning #68)sphinx-book-themeversion pinning #68 (comment))Any stylistic differences are just from the new updates to the Book Theme. I would suggest we take a "code auto-formatter" approach here and just be unopinionated and use the defaults. We can have more in depth conversations about larger theme overhauls separately if folks have strong feelings about styling.
Closes #68