Merged
Conversation
jacobtomlinson
commented
Oct 7, 2025
Comment on lines
+488
to
+490
| target_path = pathlib.Path(app.outdir) / html_src_path | ||
| target_path.parent.mkdir(parents=True, exist_ok=True) | ||
| target_path.write_text(page) |
Member
Author
There was a problem hiding this comment.
app.outdir is changing type in Sphinx 9 and is raising a deprecation warning when being used as a string. Explicitly casting to a Path resolves this.
jacobtomlinson
commented
Oct 7, 2025
jacobtomlinson
commented
Oct 7, 2025
Comment on lines
+314
to
+317
| "issue": ("https://github.com/dask/dask/issues/%s", "dask#%s"), | ||
| "pr": ("https://github.com/dask/dask/pull/%s", "dask#%s"), | ||
| "pr-distributed": ("https://github.com/dask/distributed/pull/%s", "distributed#%s"), | ||
| "pr-expr": ("https://github.com/dask/dask-expr/pull/%s", "dask-expr#%s"), |
Member
Author
There was a problem hiding this comment.
Extlinks syntax changed slightly in newer Sphinx versions
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ± 0 9 suites ±0 3h 12m 55s ⏱️ + 2m 59s Results for commit aa23cfd. ± Comparison against base commit 4736a38. This pull request removes 8 and adds 36 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-authored-by: Jacob Tomlinson <jacobtomlinson@users.noreply.github.com>
jrbourbeau
approved these changes
Oct 13, 2025
4 tasks
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out the docs theme changes from dask/dask-sphinx-theme#93
🔗 Check out the build preview to see it in action
This PR is pointing directly to that PR, so opening as a draft. Once that PR is merged and released this one needs to be updated to use the latest release before merging.