Add dask dataframe to gridsearchcv#612
Merged
TomAugspurger merged 1 commit intodask:masterfrom Feb 27, 2020
Merged
Conversation
|
i checked the errors. it seems to be timing out. do the parameters for the CI need to be changed ? |
Member
|
Trying to debug that in #613. |
Member
|
CI may be fixed, if you merge master and re-push. |
Member
Author
|
Thanks Tom!
|
adcbebe to
4b5b3ce
Compare
Member
Author
|
Green build. What do you think @TomAugspurger ? |
|
@TomAugspurger @mmccarty the gridsearchcv example you have merged uses sklearn gridsearchcv. Does that distribute on dask ? or should you update to use dask-ml gridsearchcv ? |
Member
|
What example?
…On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> @mmccarty
<https://github.com/mmccarty> the gridsearchcv example you have merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ>
.
|
|
This is the example that was committed as part of the PR
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
…On Mon, 9 Mar, 2020, 20:49 Tom Augspurger, ***@***.***> wrote:
What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
***@***.***>
wrote:
> @TomAugspurger <https://github.com/TomAugspurger> @mmccarty
> <https://github.com/mmccarty> the gridsearchcv example you have merged
> uses sklearn gridsearchcv.
>
> Does that distribute on dask ? or should you update to use dask-ml
> gridsearchcv ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ>
.
|
Member
|
That's a test checking Dask-ML's result against scikit-learn's, unless I'm
missing something..
On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa <notifications@github.com>
wrote:
… This is the example that was committed as part of the PR
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
On Mon, 9 Mar, 2020, 20:49 Tom Augspurger, ***@***.***>
wrote:
> What example?
>
> On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
> ***@***.***>
> wrote:
>
> > @TomAugspurger <https://github.com/TomAugspurger> @mmccarty
> > <https://github.com/mmccarty> the gridsearchcv example you have merged
> > uses sklearn gridsearchcv.
> >
> > Does that distribute on dask ? or should you update to use dask-ml
> > gridsearchcv ?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ>
.
|
|
Not denying that. I'm wondering if that distributes on Dask or whether the
more appropriate example would have been gridsearchcv on dask-ml.
Ultimately if gridsearchcv on sklearn does not distribute... then would the
example be relevant for actual use ?
…On Mon, 9 Mar, 2020, 21:13 Tom Augspurger, ***@***.***> wrote:
That's a test checking Dask-ML's result against scikit-learn's, unless I'm
missing something..
On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa <
***@***.***>
wrote:
> This is the example that was committed as part of the PR
>
>
>
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
>
> On Mon, 9 Mar, 2020, 20:49 Tom Augspurger, ***@***.***>
> wrote:
>
> > What example?
> >
> > On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
> > ***@***.***>
> > wrote:
> >
> > > @TomAugspurger <https://github.com/TomAugspurger> @mmccarty
> > > <https://github.com/mmccarty> the gridsearchcv example you have
merged
> > > uses sklearn gridsearchcv.
> > >
> > > Does that distribute on dask ? or should you update to use dask-ml
> > > gridsearchcv ?
> > >
> > > —
> > > You are receiving this because you were mentioned.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
>
#612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
>
#612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#612?email_source=notifications&email_token=AAASYU752H3EGMEGK4OEU6DRGUFDLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHYQEY#issuecomment-596609043>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASYU6BR2GF2EVG32HHQR3RGUFDLANCNFSM4KXQ6SOQ>
.
|
Member
|
I'm not sure I follow, but I think the test looks OK.
On Mon, Mar 9, 2020 at 10:47 AM Sandeep Srinivasa <notifications@github.com>
wrote:
… Not denying that. I'm wondering if that distributes on Dask or whether the
more appropriate example would have been gridsearchcv on dask-ml.
Ultimately if gridsearchcv on sklearn does not distribute... then would the
example be relevant for actual use ?
On Mon, 9 Mar, 2020, 21:13 Tom Augspurger, ***@***.***>
wrote:
> That's a test checking Dask-ML's result against scikit-learn's, unless
I'm
> missing something..
>
> On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa <
> ***@***.***>
> wrote:
>
> > This is the example that was committed as part of the PR
> >
> >
> >
>
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
> >
> > On Mon, 9 Mar, 2020, 20:49 Tom Augspurger, ***@***.***>
> > wrote:
> >
> > > What example?
> > >
> > > On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
> > > ***@***.***>
> > > wrote:
> > >
> > > > @TomAugspurger <https://github.com/TomAugspurger> @mmccarty
> > > > <https://github.com/mmccarty> the gridsearchcv example you have
> merged
> > > > uses sklearn gridsearchcv.
> > > >
> > > > Does that distribute on dask ? or should you update to use dask-ml
> > > > gridsearchcv ?
> > > >
> > > > —
> > > > You are receiving this because you were mentioned.
> > > > Reply to this email directly, view it on GitHub
> > > > <
> > >
> >
>
#612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305
> > > >,
> > > > or unsubscribe
> > > > <
> > >
> >
>
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
> > > >
> > > > .
> > > >
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
>
#612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170
> > >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#612?email_source=notifications&email_token=AAASYU752H3EGMEGK4OEU6DRGUFDLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHYQEY#issuecomment-596609043
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAASYU6BR2GF2EVG32HHQR3RGUFDLANCNFSM4KXQ6SOQ
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#612?email_source=notifications&email_token=AAKAOIU6RSYRVHNQW7NHLMLRGUFQ3A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHY7ZA#issuecomment-596611044>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIXNWB6FSTMXN72GIT3RGUFQ3ANCNFSM4KXQ6SOQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
Adds Dask DataFrame support to GridSearchCV.