Open
Conversation
Merging from dask/dask-ml
merging from dask-ml
Closes DAS-1146: Sample weight metric calculations
Member
|
Can you ping me here when the scikit-learn version is merged / closed? I don't have time to follow it at the moment. |
DS-126 Update patch on Dask-ml v1.3.0
Merge v1.3.0 dask-ml feature branch into master. Updates ZEFR/dask-ml to catch up to official v1.3.0
…-ml-1.6.0 RLS: v.1.6.0
Merge dask ml 1.6.0
Fixes to unittests
|
this might be of interest here: scikit-learn/scikit-learn#26896 (and other metadata routing work we're doing now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #480. See also:
What does this implement/fix? Explain your changes.
This PR adds sample_weight to metrics in cross validation routines by propagating the sample_weight parameter passed to fit_params. It does not provide the ability to use different sample_weight values in validation.
Any other comments?
A scikit-learn version of this PR has been created at scikit-learn/scikit-learn#13432
For more detailed information on the motivation for this PR, see http://deaktator.github.io/2019/03/10/the-error-in-the-comparator/