Conversation
| elif da.Array in types: | ||
| return da.hstack(Xs) | ||
| # To avoid changing dask core, this is the definition of the | ||
| # dask.array.hstack inlined: |
There was a problem hiding this comment.
We're releasing fairly frequently these days. If you're willing I encourage you to submit a small PR that passes allow_unknown_chunksizes through the hstack vstack, ... functions in dask.array. That seems like it would benefit other applications as well.
There was a problem hiding this comment.
I created this PR to push this forward: dask/dask#4287
There was a problem hiding this comment.
Thanks @vecchp.
I think we'll keep this compatibility code to allow us to pin our minimum bound at dask 1.0 for a while.
@ryan-deak-zefr could you update the comment to reflect that?
There was a problem hiding this comment.
@TomAugspurger: Please let me know if the current comment is sufficient.
TomAugspurger
left a comment
There was a problem hiding this comment.
I'm hoping to have all the CI issues sorted out tomorrow.
| elif da.Array in types: | ||
| return da.hstack(Xs) | ||
| # To avoid changing dask core, this is the definition of the | ||
| # dask.array.hstack inlined: |
There was a problem hiding this comment.
Thanks @vecchp.
I think we'll keep this compatibility code to allow us to pin our minimum bound at dask 1.0 for a while.
@ryan-deak-zefr could you update the comment to reflect that?
|
Looks good. I've pushed a commit merging master to your branch. CI should pass now. |
|
Thanks! |
|
Thank @TomAugspurger! |
Closes #436.
To fix, set
allow_unknown_chunksizes=Trueby default indask_ml.compose.ColumnTransformer._hstack.