Skip to content

Add allow_unknown_chunksizes to hstack and vstack#4287

Merged
mrocklin merged 7 commits intodask:masterfrom
vecchp:hsack_vstack_allow_unknown_chunksizes
Dec 11, 2018
Merged

Add allow_unknown_chunksizes to hstack and vstack#4287
mrocklin merged 7 commits intodask:masterfrom
vecchp:hsack_vstack_allow_unknown_chunksizes

Conversation

@vecchp
Copy link
Copy Markdown

@vecchp vecchp commented Dec 11, 2018

Adds allow_unknown_chunksizes parameter to hstack and vstack as discussed in: dask/dask-ml#437

  • Tests added / passed
  • Passes flake8 dask

@vecchp vecchp mentioned this pull request Dec 11, 2018
@vecchp
Copy link
Copy Markdown
Author

vecchp commented Dec 11, 2018

@mrocklin It looks like the Python 3.6 build is failing duo to a boto3 import error. Is there a separate PR for this or do we need to fix it here?

@jrbourbeau
Copy link
Copy Markdown
Member

There is a separate PR (see #4276) to fix the boto issue

@mrocklin
Copy link
Copy Markdown
Member

This looks good to me. Thank you for fixing this @vecchp . Merging!

Also, I notice that this is your first code contribution to this repository. Welcome!

@mrocklin mrocklin merged commit bb50d41 into dask:master Dec 11, 2018
@vecchp
Copy link
Copy Markdown
Author

vecchp commented Dec 11, 2018

Thanks!

@vecchp vecchp deleted the hsack_vstack_allow_unknown_chunksizes branch December 11, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants