MAINT: ndarrays for score (and move ndarray logic from partial_fit to fit)#246
Merged
TomAugspurger merged 4 commits intodask:masterfrom Jun 29, 2018
Merged
MAINT: ndarrays for score (and move ndarray logic from partial_fit to fit)#246TomAugspurger merged 4 commits intodask:masterfrom
TomAugspurger merged 4 commits intodask:masterfrom
Conversation
TomAugspurger
approved these changes
Jun 29, 2018
dask_ml/wrappers.py
Outdated
| from ._partial import fit | ||
| from ._utils import copy_learned_attributes | ||
| from .metrics import get_scorer, check_scoring | ||
| from sklearn.metrics import get_scorer as sklearn_get_scorer |
Member
There was a problem hiding this comment.
Slight preference for just using import sklearn.metrics and then sklearn.metrics.get_scorer (we'll soon have more space to work with :)
Member
|
Thanks @stsievert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
Two changes:
ParallelPostFitto accepts score ndarrays if passed by using sklearn'sget_scorer.Incremental.fit(which works becausepartial_fitcallsfit).