Fit immediately in Incremental.partial_fit on concrete inputs#236
Merged
TomAugspurger merged 2 commits intodask:masterfrom Jun 28, 2018
Merged
Fit immediately in Incremental.partial_fit on concrete inputs#236TomAugspurger merged 2 commits intodask:masterfrom
TomAugspurger merged 2 commits intodask:masterfrom
Conversation
| return self.fit(X, y=y, **fit_kwargs) | ||
| if not dask.is_dask_collection(X) and not dask.is_dask_collection(y): | ||
| self.estimator.partial_fit(X=X, y=y, **fit_kwargs) | ||
| return self |
Member
There was a problem hiding this comment.
Perhaps a copy_learned_attributes(self.estimator, self) before returning.
TomAugspurger
approved these changes
Jun 28, 2018
Member
Author
|
Thanks for the commit @TomAugspurger
…On Thu, Jun 28, 2018 at 10:57 AM, Tom Augspurger ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#236 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszJ5fX3xh-Qz3gCIjW3Z2GxjPDKn8ks5uBO7MgaJpZM4U6LdH>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.