MAINT: accept ndarrays for input to fit and predict#224
Merged
TomAugspurger merged 1 commit intodask:masterfrom Jun 23, 2018
Merged
MAINT: accept ndarrays for input to fit and predict#224TomAugspurger merged 1 commit intodask:masterfrom
TomAugspurger merged 1 commit intodask:masterfrom
Conversation
| if isinstance(z_, da.Array): | ||
| assert result.chunks == ((2, 2),) | ||
| assert isinstance(result, da.Array) | ||
| assert result.compute().tolist() == sol.tolist() |
Member
There was a problem hiding this comment.
FYI, we'd typically use dask.array.utils.assert_eq (I know you didn't write this test).
Member
Author
There was a problem hiding this comment.
Good to know. I thought that seemed clunky.
This was referenced Jun 23, 2018
stsievert
added a commit
to stsievert/dask-ml
that referenced
this pull request
Jun 28, 2018
This reverts commit 5db49e9.
TomAugspurger
added a commit
that referenced
this pull request
Jun 29, 2018
Revert "MAINT: accept ndarrays for input to fit and predict (#224)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements and tests
fitandpredictpredictreturn the same type as the argument passed inThis generalizes to
Incrementalbecause it callsfit.