Warn that cloudpickle is not always deterministic#9148
Merged
jrbourbeau merged 3 commits intodask:mainfrom Jun 6, 2022
Merged
Conversation
ian-r-rose
reviewed
Jun 1, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
Thanks @pavithraes! The fix looks good to me, just a couple of minor suggestions on the test
pavithraes
commented
Jun 2, 2022
ian-r-rose
approved these changes
Jun 2, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
LGTM, thanks @pavithraes
Collaborator
|
Test failure should be fixed by #9154 |
Member
|
Restarted the failed CI job now that PR ( #9154 ) is merged |
jrbourbeau
approved these changes
Jun 6, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @pavithraes -- this is in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
tokenizetakes the cloudpickle path, it may not always get deterministic tokens. It'll be nice to warn about this if thetokenize.ensure-deterministicconfig is set to True.pre-commit run --all-files