Merged
Conversation
Collaborator
Author
|
🤷 seems okay to me, shall we take it for a spin? |
jrbourbeau
approved these changes
Jun 1, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ian-r-rose. Happy to give this a try, but it would be good to get a couple other CI runs to pass just to have a bit more confidence that this fixes things. Just pushed up an empty commit to see if things are green again
3 tasks
jakirkham
approved these changes
Jun 2, 2022
Member
jakirkham
left a comment
There was a problem hiding this comment.
LGTM. Seems like the next run still passed. Anything else we want to do here?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #8816