Conversation
Member
|
Thanks Rick! |
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
…` and ``aggregate_files`` (dask#9052) As discussed in dask#9043 (for `chunksize`) and dask#9051 (for `aggregate_files`), I propose that we deprecate two complex and rarely-utilized arguments from `read_parquet`: `chunksize` and `aggregate_files`. This PR simply adds "pre-deprectation" warnings for the targeted arguments (including links to the relevant Issues discussing their deprecation). My goal is to find (and inform) whatever users may be depending on these obscure options.
jcrist
reviewed
May 27, 2022
| "metadata_task_size": metadata_task_size, | ||
| "split_row_groups": split_row_groups, | ||
| "chunksize=": chunksize, | ||
| "chunksize": chunksize, |
Member
There was a problem hiding this comment.
Just saw this change - this looks like there was a bug in the chunksize implementation that made it not actually work before, is that correct? If so, that may be further evidence that this option can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #9043 (for
chunksize) and #9051 (foraggregate_files), I propose that we deprecate two complex and rarely-utilized arguments fromread_parquet:chunksizeandaggregate_files.This PR simply adds "pre-deprectation" warnings for the targeted arguments (including links to the relevant Issues discussing their deprecation). My goal is to find (and inform) whatever users may be depending on these obscure options.