Skip to content

Update ensure_bytes#9050

Merged
jrbourbeau merged 3 commits intodask:mainfrom
jakirkham:update_ensure_bytes
May 6, 2022
Merged

Update ensure_bytes#9050
jrbourbeau merged 3 commits intodask:mainfrom
jakirkham:update_ensure_bytes

Conversation

@jakirkham
Copy link
Copy Markdown
Member

Currently both Dask and Distributed implement this function with very slight variations. To attempt to consolidate these, pull in the Distributed implementation content into the Dask implementation. Then both Dask & Distributed can use this one function.


  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

jakirkham added 2 commits May 6, 2022 09:50
Currently both Dask and Distributed implement this function with very
slight variations. To attempt to consolidate these, pull in the
Distributed implementation content into the Dask implementation. Then
both Dask & Distributed can use this one function.
@jakirkham jakirkham force-pushed the update_ensure_bytes branch from b4b9ec2 to 2ca1eca Compare May 6, 2022 17:38
@jakirkham
Copy link
Copy Markdown
Member Author

@dask/maintenance, any thoughts on this? 🙂

@jakirkham jakirkham added needs review Needs review from a contributor. hygiene Improve code quality and reduce maintenance overhead labels May 6, 2022
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham -- LGTM

@jrbourbeau jrbourbeau merged commit 8e596ce into dask:main May 6, 2022
@jakirkham jakirkham deleted the update_ensure_bytes branch May 6, 2022 20:40
@jakirkham
Copy link
Copy Markdown
Member Author

Thanks James! 😄

@jakirkham jakirkham removed the needs review Needs review from a contributor. label May 6, 2022
erayaslan pushed a commit to erayaslan/dask that referenced this pull request May 12, 2022
Currently both Dask and Distributed implement this function with very
slight variations. To attempt to consolidate these, pull in the
Distributed implementation content into the Dask implementation. Then
both Dask & Distributed can use this one function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hygiene Improve code quality and reduce maintenance overhead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants