Skip to content

Fix flaky test_reductions_2D#9037

Merged
jrbourbeau merged 1 commit intodask:mainfrom
jcrist:fixup-failing-test-reductions-2D
May 5, 2022
Merged

Fix flaky test_reductions_2D#9037
jrbourbeau merged 1 commit intodask:mainfrom
jcrist:fixup-failing-test-reductions-2D

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented May 5, 2022

prod/nanprod overflow for data at this size. It's not clear why
numpy only raises these warnings sometimes, but it makes sense why
they're there. We filter RuntimeWarning now for prod/nanprod (and
only these operations) now to fix this.

Closes #8892

`prod`/`nanprod` overflow for data at this size. It's not clear why
numpy only raises these warnings _sometimes_, but it makes sense why
they're there. We filter `RuntimeWarning` now for `prod`/`nanprod` (and
only these operations) now to fix this.
@github-actions github-actions bot added the array label May 5, 2022
@jrbourbeau jrbourbeau changed the title Fixup flaky test_reductions_2D Fix flaky test_reductions_2D May 5, 2022
@jrbourbeau jrbourbeau merged commit 8fbdb4a into dask:main May 5, 2022
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcrist

@jcrist jcrist deleted the fixup-failing-test-reductions-2D branch May 5, 2022 18:25
erayaslan pushed a commit to erayaslan/dask that referenced this pull request May 12, 2022
`prod`/`nanprod` overflow for data at this size. It's not clear why
numpy only raises these warnings _sometimes_, but it makes sense why
they're there. We filter `RuntimeWarning` now for `prod`/`nanprod` (and
only these operations) now to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_reductions_2D flaky

2 participants