Prevent codecov from notifying of failure too soon#9031
Merged
Conversation
Currently codecov pushes an initial failing status on every PR that is later updated to passing once more CI builds finish. This is annoying. As far as I can tell from https://docs.codecov.com/docs/merging-reports this shouldn't be happening, but it is. Here we attempt to stop this behavior by: - Only running code coverage on the main test suite that hits most of the codebase. - Setting a minimum number of builds before codecov should push a status update. Hopefully this fixes the problem.
ian-r-rose
approved these changes
May 5, 2022
jrbourbeau
reviewed
May 5, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Totally agree the early red "X" isn't great. Did we need to drop coverage on the additional builds, or would increasing after_n_builds higher to like 5 or 6 be sufficient?
Member
Author
|
We could have done that, but the mindeps builds are a subset of the normal builds afaict, and so extra coverage there shouldn't be necessary. |
Member
|
The mindeps builds are a subset, but they provide coverage for guarded imports and some version-dependent logic like Line 3698 in 4d6a5f0 To be clear, this definitely isn't many lines of code, but I don't see why we shouldn't include it if it doesn't introduce problems elsewhere |
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
Currently codecov pushes an initial failing status on every PR that is later updated to passing once more CI builds finish. This is annoying. As far as I can tell from https://docs.codecov.com/docs/merging-reports this shouldn't be happening, but it is. Here we attempt to stop this behavior by: - Only running code coverage on the main test suite that hits most of the codebase. - Setting a minimum number of builds before codecov should push a status update. Hopefully this fixes the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently codecov pushes an initial failing status on every PR that is
later updated to passing once more CI builds finish. This is annoying.
As far as I can tell from https://docs.codecov.com/docs/merging-reports
this shouldn't be happening, but it is. Here we attempt to stop this
behavior by:
the codebase.
update.
Hopefully this fixes the problem.