Band-aid for compute_as_if_collection#8998
Merged
Conversation
added 2 commits
April 28, 2022 16:12
could result in bad dependency information and thereby bad scheduling when used in `compute_as_if_collection`
jcrist
approved these changes
May 5, 2022
jrbourbeau
reviewed
May 5, 2022
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
* Temporary band-aid to force the deletion of dsk.key_dependencies, which could result in bad dependency information and thereby bad scheduling when used in `compute_as_if_collection` * Typo
TomAugspurger
added a commit
to TomAugspurger/dask
that referenced
this pull request
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary band-aid for #8991 to force the deletion of
dsk.key_dependencies, which could result in bad dependency information and thereby bad scheduling when used incompute_as_if_collection. I'm agnostic as to whether this should ever be merged. The test doesn't really even directly probe the fix, I've mostly included it for illustrative purposes.pre-commit run --all-files