Fix overlapping divisions error on append#8997
Merged
Conversation
added 3 commits
April 28, 2022 13:34
the last partition, as these should be considered overlapping partitions.
jcrist
approved these changes
May 5, 2022
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
* Change test to also look for *slightly* overlapping divisions. * Also raise if the start of an appended partition is equal to the end of the last partition, as these should be considered overlapping partitions. * Remove commented-out code. * Remove kwarg which is new in pandas 1.4, the default behavior is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesWe were not being as picky as we should have been when it comes to overlapping divisions upon appending to an existing parquet dataset. Here we also raise if they slightly overlap (that is to say, if the first index value in the new partition == the last index value of the previous partition).