Fix #8978 - do not attempt to clone literals.#8979
Merged
Conversation
jsignell
reviewed
Apr 27, 2022
Co-authored-by: Julia Signell <jsignell@gmail.com>
crusaderky
reviewed
May 4, 2022
Collaborator
|
Apologies for the late response. |
Contributor
Author
|
Thanks for the feedback - I will write a unit test when I have a moment. |
Contributor
Author
|
@crusaderky, @jsignell I have added a very rudimentary test - let me know if you want it to be more sophisticated. At present it mainly serves to check that |
Contributor
Author
|
Not sure what is up with the broken test - nothing to do with this PR though. |
Member
|
Yeah that failed test looks unrelated. Thank you for this work @JSKenyon! |
erayaslan
pushed a commit
to erayaslan/dask
that referenced
this pull request
May 12, 2022
crusaderky
added a commit
to crusaderky/dask
that referenced
this pull request
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blockwise.clonedoesn't handle (iterable) literal arguments correctly #8978pre-commit run --all-filesThis should be a simple fix for #8978. Unless I am mistaken,
idxvshould always beNonefor literals, and literals should simply be included as-is in the cloned graph.