Add deprecation warning for pyarow-legacy engine#8758
Merged
Conversation
This was referenced Feb 25, 2022
Member
|
@martindurant would you have time to look? 🙂 |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
| ) | ||
|
|
||
| if engine == "pyarrow-dataset": | ||
| if pa_version.major < 1: |
Member
There was a problem hiding this comment.
Can we not require >1 by now?
Sorry, that's exactly what you are doing.
Member
Author
There was a problem hiding this comment.
We probably can since we dropped 3.7 support, but pyarrow-1 should still work with the pyarrow-dataset engine. I figured we could bump this later on when needed, but I'm open to anything
Member
There was a problem hiding this comment.
What you have is fine. We'll simply remove the whole thing soon enough!
Member
|
+1 |
Member
Author
|
Thanks @martindurant and @jorisvandenbossche for taking a look so quickly! |
Member
|
Woo |
Member
|
Thanks all! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to work on some parquet cleanup and documentation, and dropping support for
ArrowLegacyEnginewill certainly simplify things. This PR adds a deprecation warning forengine="pyarrow-legacy".I plan to submit a follow-up PR after 1-2 releases to remove
ArrowLegacyEnginealtogether.pre-commit run --all-files