Conversation
|
Just pushed an empty commit to test against the |
|
Yep. I thought that restarting the tests would have the same effect, but maybe not. |
|
This does not seem to be picking up fastparquet main in every run. Do I need to make a release? The (parquet) tests do all pass for me locally. |
|
Only the upstream test will pick up fastparquet from main. So yeah I think a release would be necessary to get the regular tests passing. |
|
OK; well upstream seems to be failing on loads of dataframe tests (from warnings?). They include some parquet, but I cannot tell if these are actually parquet failures or due to whatever broke elsewhere. |
|
Comparing the failing test summary between the linux Python 3.9 build (which is using |
|
OK, so we merge and I'll release fastparquet? There are a couple of PRs waiting there that would be nice to get in first. |
|
A |
|
Coming... dask/fastparquet#739 |
|
Woo 🎉 |
|
Ok I am going to merge this and then we should be all green???? :) |
|
Thank you @martindurant for the quick turn around on this! |
|
Hope! Note that conda-forge did it's job, which is what matters here, but some pypi wheels didn't build. I'll track those down later. |
|
Thanks @martindurant @jsignell! |
pre-commit run --all-filesAlso requires dask/fastparquet#738