Cleaning up misc tests for pandas compat#8623
Merged
Conversation
jrbourbeau
reviewed
Jan 25, 2022
| ds = dd.from_pandas(s, 2) | ||
| res = dd.get_dummies(ds, dummy_na=True) | ||
| assert_eq(res, exp) | ||
| tm.assert_index_equal(res.columns, pd.Index([1, 2, 3, 5, np.nan])) |
Member
There was a problem hiding this comment.
This tm.assert_index_equal call fails with
E AssertionError: Index are different
E
E Index classes are different
E [left]: CategoricalIndex([1, 2, 3, 5, nan], categories=[1, 2, 3, 5], ordered=False, dtype='category')
E [right]: Float64Index([1.0, 2.0, 3.0, 5.0, nan], dtype='float64')but all the other tm.assert_index_equal calls in this test pass on pandas 1.4.0. Why are we removing the other asserts?
Alternatively, could we just update this line to use pd.Index([1, 2, 3, 5, np.nan], dtype=res.columns.dtype) instead?
Member
Author
There was a problem hiding this comment.
The index is already being checked in assert_eq. I imagine that this tests was just outdated.
Member
Author
|
Ok I think this one is good to go! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: