Fork out percentile_dispatch to dask.array#8083
Conversation
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @galipremsagar! Overall this looks good. I've left a few small comments below
dask/array/dispatch.py
Outdated
| def _percentile(a, q, interpolation="linear"): | ||
| return percentile_dispatch(a, q, interpolation) |
There was a problem hiding this comment.
Is this needed? Can we just rely on percentile_dispatch.__call__ instead?
There was a problem hiding this comment.
Yes, removed this. Is there a plan to replace this kind of dispatch invocation to other dispatches? Not in scope of PR but wanted to know.
There was a problem hiding this comment.
No concrete plan, but if we're able to safely remove similar wrapper functions, then I'd be +1
|
Thanks for all the updates @galipremsagar, they look great! It looks like the gpuCI build isn't happy with some of the changes here. We're getting error s like |
Yeah, I can make the changes on |
jrbourbeau
left a comment
There was a problem hiding this comment.
Sounds good to me 👍 Will merge once CI finishes. Thanks again for handling this.
This PR adds backend for `percentile_lookup` dispatch in `dask_cudf`, related dask upstream changes were done in dask/dask#8083 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - https://github.com/jakirkham URL: #9118
black dask/flake8 dask/isort dask