Fix __array_function__ dispatching for tril/triu#7457
Conversation
Illviljan
left a comment
There was a problem hiding this comment.
Hello, I added some comments.
Although it might be necessary I think it's a little unfortunate that you had to reimagine the implementation a bit. When I added it was pretty much a straight copy/paste from numpy. It made it very easy to review and see through possible errors (although not the cupy errors apparently...). But the numpy implementation has already changed since I copy/pasted it so keeping up with upstream is not easy.
Thank you! They should all have been addressed now.
Yes, supporting multiple backends can come with this sort of adapting when some functionality isn't supported. With that said, I'm not really worried about Dask having a diverging implementation to that of NumPy, due to its different requirements and different project paces it's generally impractical to keep everything in sync. Regardless of that, the new code is indeed much simpler than it used to be, thanks for working on that! |
|
Thanks John for merging! |
This PR fixes
__array_function__dispatching fortril/triu, which broke for downstream libraries such as CuPy after #6997 .black dask/flake8 dask