Remove duplicated imports from test_slicing.py#7365
Merged
jrbourbeau merged 2 commits intodask:mainfrom Mar 11, 2021
Merged
Conversation
jrbourbeau
reviewed
Mar 11, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Good catch, thanks @hristog! I pushed an empty commit to rerun CI to see if the test failure is related to the changes here (it looks totally unrelated).
Contributor
Author
|
Hi @jrbourbeau - thanks for looking into this and for confirming via an empty commit! I discovered this during getting myself acquainted with the unit-test infrastructure, as I was trying to debug what I've reported under dask/dask-ml#803. I'll continue investigating the |
Member
|
Also I noticed this was your first code contribution to this repository. Welcome! |
Contributor
Author
Indeed! Thank you :) |
douglasdavis
pushed a commit
to douglasdavis/dask
that referenced
this pull request
Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxxN/A (If the maintainers are happy with the proposed update, should a corresponding issue be created and referenced here?)black dask/flake8 daskIt appears that the unintentional copy of
imports (if it was indeed unintentional) originated in 51ff4e6.