Skip to content

Revert BlockwiseIO#7048

Merged
jacobtomlinson merged 3 commits intodask:masterfrom
rjzamora:revert-blockwiseio
Jan 13, 2021
Merged

Revert BlockwiseIO#7048
jacobtomlinson merged 3 commits intodask:masterfrom
rjzamora:revert-blockwiseio

Conversation

@rjzamora
Copy link
Member

@rjzamora rjzamora commented Jan 8, 2021

Following the suggestion in #7042, this PR is meant to (temporarily) revert the recent BlockwiseIO changes until #7042 can be merged with a suitable replacement.

Closes #7005
Closes #7017

TODO

  • Fix annotation-related failures

@jacobtomlinson
Copy link
Member

Thanks @rjzamora.

Is this PR blocked on the TODO item?

@rjzamora
Copy link
Member Author

Is this PR blocked on the TODO item?

Ah - Sorry @jacobtomlinson - That TODO is done (must have double-clicked it or something...)

@jacobtomlinson
Copy link
Member

Awesome! In that case let's get it in.

@jacobtomlinson jacobtomlinson merged commit b31844d into dask:master Jan 13, 2021
@jrbourbeau
Copy link
Member

Thanks @rjzamora @jacobtomlinson

@rjzamora rjzamora deleted the revert-blockwiseio branch January 14, 2021 15:45
abduhbm pushed a commit to abduhbm/dask that referenced this pull request Jan 19, 2021
* revert BlockwiseIO changes

* add missing test

* add back test_blockwise_parquet_annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename columns fails after read_parquet with ValueError: Unable to coerce to Series ValueError in groupby.get_group from read_csv

3 participants