Skip to content

Efficient serialization of shuffle layers#6760

Merged
jrbourbeau merged 2 commits intodask:masterfrom
jrbourbeau:shuffle-layer-serialize
Oct 23, 2020
Merged

Efficient serialization of shuffle layers#6760
jrbourbeau merged 2 commits intodask:masterfrom
jrbourbeau:shuffle-layer-serialize

Conversation

@jrbourbeau
Copy link
Member

Following up on #6693 and #6650 this PR overloads __reduce__ on our new shuffle layers to avoid materializing the underlying low-level task graph for when we start sending these layers to the distributed scheduler

cc @madsbk @rjzamora

  • Tests added / passed
  • Passes black dask / flake8 dask

Copy link
Contributor

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrbourbeau
Copy link
Member Author

Thanks for reviewing @madsbk!

@jrbourbeau jrbourbeau merged commit 81c24bf into dask:master Oct 23, 2020
@jrbourbeau jrbourbeau deleted the shuffle-layer-serialize branch October 23, 2020 21:34
@rjzamora
Copy link
Member

Thanks @jrbourbeau !

kumarprabhu1988 pushed a commit to kumarprabhu1988/dask that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants