CI: Fixed bug causing flaky test failure in pivot#6752
Merged
TomAugspurger merged 1 commit intodask:masterfrom Oct 20, 2020
Merged
CI: Fixed bug causing flaky test failure in pivot#6752TomAugspurger merged 1 commit intodask:masterfrom
TomAugspurger merged 1 commit intodask:masterfrom
Conversation
When a partition had unobserved categories, the result MultiIndex would have the right dtype but not the right shape. This caused the `concat` to later cast to object dtype, causing the test failure. The fix is to not drop the all-NA columns. Closes dask#6729
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
When a partition had unobserved categories, the result MultiIndex would have the right dtype but not the right shape. This caused the `concat` to later cast to object dtype, causing the test failure. The fix is to not drop the all-NA columns. Closes dask#6729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a partition had unobserved categories, the result MultiIndex would
have the right dtype but not the right shape. This caused the
concatto later cast to object dtype, causing the test failure.
The fix is to not drop the all-NA columns.
Closes #6729