Add 2D possibility to da.linalg.lstsq, mirroring numpy#6749
Merged
jsignell merged 1 commit intodask:masterfrom Oct 20, 2020
Merged
Add 2D possibility to da.linalg.lstsq, mirroring numpy#6749jsignell merged 1 commit intodask:masterfrom
jsignell merged 1 commit intodask:masterfrom
Conversation
jsignell
approved these changes
Oct 20, 2020
Member
jsignell
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for submitting this PR :)
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskFixes Missing 2D case for residuals in dask.array.linalg.lstsq #6516. Two months ago I said "I can fix it this week", but here we are anyway.
This simply modifies the way residuals are compute so
dask.array.linalg.lstsq(a,b)can handle the case wherebis bidimensional, mirroring the behaviour ofnp.linalg.lstsq. The doc was also updated.