Fix meta for min/max reductions#6736
Merged
quasiben merged 4 commits intodask:masterfrom Oct 21, 2020
Merged
Conversation
quasiben
reviewed
Oct 15, 2020
Member
|
Thanks @pentschev . Left one small comment |
Member
Author
|
Anything else here @quasiben ? |
Member
|
Nope. I'll plan to merge in a few hours unless other maintainers have thoughts here |
Member
|
Thanks again @pentschev . Merging in |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
* Fix meta for min/max reductions * Add more CuPy reduction tests * Fix compute_meta ValueError exception handling
3 tasks
gjoseph92
added a commit
to gjoseph92/dask
that referenced
this pull request
May 18, 2021
gjoseph92
added a commit
to gjoseph92/dask
that referenced
this pull request
May 18, 2021
gjoseph92
added a commit
to gjoseph92/dask
that referenced
this pull request
May 18, 2021
jsignell
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Array: correct number of outputs in `apply_gufunc` * Stricter #6736 `args_meta[0]` could be wrong when there are multiple arguments. Even this I don't really like, since it's making a lot of assumptions about what `func` might be that may not be true in generality for any user-defined function. * keep std
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix meta for min/max reductions which prevented output arrays to be of the correct type, e.g., CuPy.