Skip to content

Do balanced rechunking even if chunks are the same.#6735

Merged
jsignell merged 1 commit intodask:masterfrom
deisseroth-lab:chrisroat-balance-rechunk
Oct 15, 2020
Merged

Do balanced rechunking even if chunks are the same.#6735
jsignell merged 1 commit intodask:masterfrom
deisseroth-lab:chrisroat-balance-rechunk

Conversation

@chrisroat
Copy link
Contributor

@chrisroat chrisroat commented Oct 14, 2020

The initial chunking may be unbalanced, and specifying the balance
argument indicates a desire to balance.

  • [ x ] Tests added / passed
  • [ x ] Passes black dask / flake8 dask

The initial chunking may be unbalanced, and specifying the `balance`
argument indicates a desire always balance.
@jsignell
Copy link
Member

This seems sensible to me. Ping @stsievert in case you have an opinion.

@stsievert
Copy link
Member

👍 this seems entirely reasonable.

@jsignell
Copy link
Member

Great - thanks @chrisroat!

@jsignell jsignell merged commit 98dfb92 into dask:master Oct 15, 2020
@chrisroat chrisroat deleted the chrisroat-balance-rechunk branch October 16, 2020 00:16
kumarprabhu1988 pushed a commit to kumarprabhu1988/dask that referenced this pull request Oct 29, 2020
The initial chunking may be unbalanced, and specifying the `balance`
argument indicates a desire always balance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants