Ensure HighLevelGraph layers always contain Layer instances#6716
Merged
jrbourbeau merged 4 commits intodask:masterfrom Oct 14, 2020
Merged
Ensure HighLevelGraph layers always contain Layer instances#6716jrbourbeau merged 4 commits intodask:masterfrom
jrbourbeau merged 4 commits intodask:masterfrom
Conversation
2 tasks
Member
Author
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #6707 (review), this PR moves some existing logic into
HighLevelGraph.__init__to ensure thatHighLevelGraph.layersis always a mapping from layer names andLayerinstances. Additionally, since_fix_hlg_layers_inplacewas only being called in one place, I inlined it inHighLevelGraph.__init__instead of keeping a separate method.cc @madsbk
black dask/flake8 dask