fuse_root(): update dependencies correctly#6508
Merged
mrocklin merged 4 commits intodask:masterfrom Aug 13, 2020
Merged
Conversation
Member
|
This looks good to me. Merging. I'm going to follow up with another PR that adds this to the general test suite and exposes some errors. |
mrocklin
added a commit
to mrocklin/dask
that referenced
this pull request
Aug 13, 2020
Follows on from dask#6508
mrocklin
pushed a commit
that referenced
this pull request
Sep 8, 2020
Follows on from #6508 * Added core.keys_in_tasks() * HLG: added more thorough validation check * lingalg: layer dependencies are now sets * linalg.lstsq(): fixed dependencies * linalg.sfqr(): fixed dependencies * linalg.tsqr(): removed dependency when all slices are known * linalg.tsqr(): name_q2bs are name_q2cs are not layers * added help function compute_layer_dependencies() * elemwise(): fixed dependencies * Delayed: fixed __dask_layers__() of HLGs * _loc_list(): empty dependencies on empty index * reformat: black * keys_in_tasks(): fixed doc example * optimize_blockwise(): fixed dependencies * tril() and triu(): fixed dependencies when empty result * added a doctest: +SKIP
mrocklin
pushed a commit
that referenced
this pull request
Sep 23, 2020
Follows on from #6508 * Implemented culling of high level graphs * Skip layers nobody depend on * Added class Layer(Mapping) * Implemented a default Layer.cull() * Added core.keys_in_tasks() * Layer.get_external_dependencies() to use keys_in_tasks() * Blockwise to implement the Layer protocol * optimize_blockwise(): fixed dependencies * ParquetSubgraph(): implemented Layer * Implemented HLG.keyset() * Layer.cull(): now returns a new Layer and key dependencies
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
Follows on from dask#6508 * Added core.keys_in_tasks() * HLG: added more thorough validation check * lingalg: layer dependencies are now sets * linalg.lstsq(): fixed dependencies * linalg.sfqr(): fixed dependencies * linalg.tsqr(): removed dependency when all slices are known * linalg.tsqr(): name_q2bs are name_q2cs are not layers * added help function compute_layer_dependencies() * elemwise(): fixed dependencies * Delayed: fixed __dask_layers__() of HLGs * _loc_list(): empty dependencies on empty index * reformat: black * keys_in_tasks(): fixed doc example * optimize_blockwise(): fixed dependencies * tril() and triu(): fixed dependencies when empty result * added a doctest: +SKIP
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
Follows on from dask#6508 * Implemented culling of high level graphs * Skip layers nobody depend on * Added class Layer(Mapping) * Implemented a default Layer.cull() * Added core.keys_in_tasks() * Layer.get_external_dependencies() to use keys_in_tasks() * Blockwise to implement the Layer protocol * optimize_blockwise(): fixed dependencies * ParquetSubgraph(): implemented Layer * Implemented HLG.keyset() * Layer.cull(): now returns a new Layer and key dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
fuse_roots()remove deleted layers in dependencies. Also addedHighLevelGraph.validate()that raisesValueErrorif the graph is in an invalid state.black dask/flake8 dask