Adjust parquet ArrowEngine to allow more easy subclass for writing#6505
Merged
jsignell merged 3 commits intodask:masterfrom Oct 19, 2020
Merged
Adjust parquet ArrowEngine to allow more easy subclass for writing#6505jsignell merged 3 commits intodask:masterfrom
jsignell merged 3 commits intodask:masterfrom
Conversation
Member
Author
|
cc @jsignell |
jsignell
reviewed
Aug 20, 2020
Member
jsignell
left a comment
There was a problem hiding this comment.
Just some minor comments, otherwise this looks great!
dask/dataframe/io/parquet/arrow.py
Outdated
| index_cols = [] | ||
| t = pa.Table.from_pandas(df, preserve_index=preserve_index, schema=schema) | ||
|
|
||
| t = cls._pandas_to_arrow_table(df, preserve_index, schema) |
Member
There was a problem hiding this comment.
Nitpick, but I prefer to include kwarg names.
Member
|
Ok I am planning on merging this unless anyone has worries. |
Member
Author
|
This is ready to be merged, I think? |
mariusvniekerk
approved these changes
Oct 18, 2020
Member
|
Sorry I never hit the button @jorisvandenbossche! |
Member
Author
|
No problem, thanks for merging! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
…ask#6505) * Adjust parquet ArrowEngine to allow more easy subclass for the writing part * add keyword names * blacken
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar as @mariusvniekerk's PR #6211, but now also adding an overridable method for the "pandas->arrow" conversion in the write path.
cc @rjzamora I don't think this should have any impact on other subclasses?
Context: https://github.com/jsignell/dask-geopandas/pull/13