Skip to content

Fix values in group during collections_to_dsk #6409

Merged
quasiben merged 1 commit intodask:masterfrom
quasiben:fix/optimize-base-pass
Jul 14, 2020
Merged

Fix values in group during collections_to_dsk #6409
quasiben merged 1 commit intodask:masterfrom
quasiben:fix/optimize-base-pass

Conversation

@quasiben
Copy link
Member

@quasiben quasiben commented Jul 14, 2020

@quasiben
Copy link
Member Author

quasiben commented Jul 14, 2020

Apologies for the mess here

I have tested locally with distributed master but someone should probably validate as well before merging in. FWIW I'll be more cautious moving forward

@quasiben
Copy link
Member Author

quasiben commented Jul 14, 2020

In the interest of getting CI up and running this morning I'm going to merge in. If it's an issue I'll revert changes

❯ python -c 'import dask; print(dask.__version__)'
2.20.0+10.g45a860a96
❯ py.test distributed/tests/test_client.py::test_auto_normalize_collection_sync
============================================================================================================================= test session starts ==============================================================================================================================
platform darwin -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.1
benchmark: 3.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /Users/bzaitlen/Documents/GitHub/distributed, inifile: setup.cfg
plugins: asyncio-0.10.0, benchmark-3.2.3
collected 1 item

distributed/tests/test_client.py .                                                                                                                                                                                                                                       [100%]

========================================================================================================================== slowest 10 test durations ===========================================================================================================================
2.14s teardown distributed/tests/test_client.py::test_auto_normalize_collection_sync
2.05s call     distributed/tests/test_client.py::test_auto_normalize_collection_sync
0.91s setup    distributed/tests/test_client.py::test_auto_normalize_collection_sync
============================================================================================================================== 1 passed in 5.31s ===============================================================================================================================

@quasiben quasiben merged commit 1f57364 into dask:master Jul 14, 2020
@quasiben quasiben deleted the fix/optimize-base-pass branch July 14, 2020 13:47
@mrocklin
Copy link
Member

mrocklin commented Jul 14, 2020

Thank you for taking this on @quasiben

@quasiben quasiben mentioned this pull request Jul 14, 2020
Closed
sjperkins added a commit to sjperkins/distributed that referenced this pull request Jul 15, 2020
@sjperkins
Revert "Bump delay test to account for startup"
910b329 
This reverts commit 198c29e.

dask/dask#6409
kumarprabhu1988 pushed a commit to kumarprabhu1988/dask that referenced this pull request Oct 29, 2020
@quasiben @kumarprabhu1988
groups values in optimization pass should only be graph and keys -- n…
303a0e2 
…ot an optimization + keys (dask#6409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failure on test_auto_normalize_collection_sync

2 participants

@quasiben @mrocklin