Conversation
|
This looks good to me. I'd be happy to merge, but I'll hold off until you're ready. |
|
Given the advice in the other issue I will look into other options, is it preferable to wait and add commits to this PR or would you prefer to merge and get the fixed links in sooner? I should be able to look at this over the weekend |
|
Hey @JimCircadian -- I know you were looking at |
|
Hi @gforsyth there were the broken link fixes that I found as a result of the pytest run I did (ref. the issue) so maybe worth adding these fixes to this PR? I should be able to do this Friday (deep in some other work at the moment, apologies!) |
|
No worries @JimCircadian -- I just didn't want this to get lost in the shuffle. We'll hold off on merging until you say otherwise. |
2a2ac49 to
df00c64
Compare
|
I think this is largely complete but having trouble with the CI tests at the moment, I don't think that's related to my changes. There's more discussion in the related issue, so I consider it in a good place for the moment (the links are fixed!!!) |
gforsyth
left a comment
There was a problem hiding this comment.
Hey @JimCircadian -- this is great! Thanks for testing out the various link checks and especially for searching out and finding all the new links for the rotted ones.
Once we get the CI sorted this is good to go (or even before then if someone is feeling bold).
|
Hey @JimCircadian -- can you rebase or merge master to pick up the changes there? That should remove the CI issues and we can get this in. |
|
|
Some additional items addressed: * changed permissions to remove executable bit on dask/array/gufunc.py * altered sphinx configuration to not link check localhost and github.com (rate limiting) URLs * fixed all broken links identified in make linkcheck (except for one spurious 502 from github) * modified linkcheck mechanism in make file and associated documentation dependencies
df00c64 to
1f29326
Compare
|
@gforsyth Looks good now, thanks for fixing that issue! |
gforsyth
left a comment
There was a problem hiding this comment.
Thanks for putting this in @JimCircadian ! This is good to go.
@dask/maintenance this can be merged in.
|
Also @JimCircadian, I see this is your first PR to dask. Welcome! Thanks for fixing up the docs! |
Some additional items addressed: * changed permissions to remove executable bit on dask/array/gufunc.py * altered sphinx configuration to not link check localhost and github.com (rate limiting) URLs * fixed all broken links identified in make linkcheck (except for one spurious 502 from github) * modified linkcheck mechanism in make file and associated documentation dependencies
Some additional items addressed:
black dask/flake8 daskDraft request currently, as part of 4058 will investigate whether any other alterations are required to support CI and what impact the removal of github checks have before finalising