Skip to content

Use pytest.warns to check for UserWarning in test_parquet.py#6378

Merged
mrocklin merged 1 commit intodask:masterfrom
rjzamora:warning-fix
Jul 9, 2020
Merged

Use pytest.warns to check for UserWarning in test_parquet.py#6378
mrocklin merged 1 commit intodask:masterfrom
rjzamora:warning-fix

Conversation

@rjzamora
Copy link
Member

@rjzamora rjzamora commented Jul 8, 2020

May address a nightly-pyarrow CI failure

It seems that test_illegal_column_name may be checking for a UserWarning in a fragile way - This may fix the pyarrow CI problem. cc @jorisvandenbossche

  • Tests added / passed
  • Passes black dask / flake8 dask

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@mrocklin mrocklin merged commit d8a1b2f into dask:master Jul 9, 2020
@mrocklin
Copy link
Member

mrocklin commented Jul 9, 2020

Thanks @rjzamora !

@rjzamora rjzamora deleted the warning-fix branch July 9, 2020 02:54
kumarprabhu1988 pushed a commit to kumarprabhu1988/dask that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants