Parse bytes_per_chunk keyword from string#6370
Merged
TomAugspurger merged 1 commit intodask:masterfrom Jul 6, 2020
Merged
Conversation
| db, | ||
| columns=list(df.columns), | ||
| bytes_per_chunk=2 ** 30, | ||
| bytes_per_chunk="2 GiB", |
Member
There was a problem hiding this comment.
Could you test both of these cases, to ensure that we don't regress on accepting integers?
Member
Author
There was a problem hiding this comment.
I flopped around some of the current uses of this keyword in the test suite to strings while leaving some others as integers. I think that we're covered in both cases, even if there isn't an explicit test. I can make an explicit test though if preferred.
Member
There was a problem hiding this comment.
As long as we have some coverage for passing integers I think we're good.
Member
|
Thanks! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://stackoverflow.com/questions/62700350/storing-dask-dataframes-to-parquet-when-data-doesnt-fit-in-memory
black dask/flake8 dask