Handle unnamed pandas RangeIndex in fastparquet engine#6350
Merged
TomAugspurger merged 3 commits intodask:masterfrom Jun 29, 2020
Merged
Handle unnamed pandas RangeIndex in fastparquet engine#6350TomAugspurger merged 3 commits intodask:masterfrom
TomAugspurger merged 3 commits intodask:masterfrom
Conversation
TomAugspurger
approved these changes
Jun 29, 2020
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
cc @martindurant. Merging later today if there's no objections.
| rg_piece = pf.row_groups[piece] | ||
| pf.fmd.key_value_metadata = None | ||
| if null_index_name: | ||
| if "__index_level_0__" in pf.columns: |
Member
There was a problem hiding this comment.
You may wish to add comments here, to explain this.
It may be nice to upstream this to fastparquet, not urgent.
Member
|
+1 |
Member
Author
|
Hmm - Seems that CI broke after a comment-only commit here. |
Member
|
Strange. I restarted that job. |
Member
|
Thanks @rjzamora! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
* handle null-named rangeindex in fastparquet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6348
Modifies
FastParquetEngineto use the "pandas metadata" to handle round-tripping unnamedRangeIndexcolumns from pandas.black dask/flake8 dask