Fix rechunking of arrays with some zero-length dimensions.#6335
Merged
TomAugspurger merged 1 commit intodask:masterfrom Jun 19, 2020
Merged
Fix rechunking of arrays with some zero-length dimensions.#6335TomAugspurger merged 1 commit intodask:masterfrom
TomAugspurger merged 1 commit intodask:masterfrom
Conversation
Contributor
Author
|
Likely "introduced" by #6233 |
Carreau
commented
Jun 19, 2020
jrbourbeau
reviewed
Jun 19, 2020
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the fix @Carreau! Overall the changes here look great, just left a couple of small comments
While the arrays are _technically_ empty and contain no values, the rechunking code does update the chunk size metadata.
Contributor
Author
|
util function extracted, rebased and force-pushed. |
TomAugspurger
approved these changes
Jun 19, 2020
Member
|
Thanks @Carreau! |
kumarprabhu1988
pushed a commit
to kumarprabhu1988/dask
that referenced
this pull request
Oct 29, 2020
While the arrays are _technically_ empty and contain no values, the rechunking code does update the chunk size metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the arrays are technically empty and contain no values,
the rechunking code does update the chunk size metadata.
black dask/flake8 dask