Normalize Xarray datasets to Dask arrays #4756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
approved these changes
Apr 30, 2019
Member
shoyer
left a comment
There was a problem hiding this comment.
Thanks, this looks like the right way to handle xarray objects in dask. (Short of a more generic numpy duck-typing protocol that we could use instead)
| def test_xarray(): | ||
| y = da.mean(xr.DataArray([1, 2, 3.0])) | ||
|
|
||
| assert_eq(y, y) |
Member
There was a problem hiding this comment.
does this verify that the type of the result is a dask array? assert isinstance(y, da.Array) might be a more direct way to do this.
Member
Author
There was a problem hiding this comment.
Well, I could imagine future behavior being that the result here is an Xarray thing rather than a Dask thing. I actually don't care too much about the output, as long as it computes and is self-consistent.
Member
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4532
flake8 daskcc @mraspaud @shoyer if you have time to take a look at this I would appreciate it.