Calling np.dtype on a delayed object works #4387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `np.dtype(dask.delayed(...))` used to result in a segfault, as numpy recursively tries to get `dtype` from the object. This is likely a bug in numpy. For now, we can do a dumb for if `x.dtype().dtype()` is called (which shouldn't ever show up in real code). See dask#4374 (comment).
This was referenced Jan 15, 2019
Merged
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
For now, we can do a dumb for if x.dtype().dtype()
When you first said you had a patch in mind, I was worried you'd need to some frame introspection :) This is much better.
And we probably have tests for this, but can you double check that basics of .dtype on a delayed object with an actual dtype are tested still work? Delayed(np.array([])).dtype
TomAugspurger
approved these changes
Jan 15, 2019
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
* Calling np.dtype on a delayed object works Calling `np.dtype(dask.delayed(...))` used to result in a segfault, as numpy recursively tries to get `dtype` from the object. This is likely a bug in numpy. For now, we can do a dumb for if `x.dtype().dtype()` is called (which shouldn't ever show up in real code). See dask#4374 (comment). * Add test that dtype attribute still works if computed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
np.dtype(dask.delayed(...))used to result in a segfault, asnumpy recursively tries to get
dtypefrom the object. This is likely abug in numpy. For now, we can do a dumb check for if
x.dtype.dtypeiscalled (which shouldn't ever show up in real code).
See #4374 (comment).