Re-enable multifield copy->view change#4357
Conversation
|
I think this warrants a short explanation and links to the 3PRs that touched the code. |
|
Those requests seem quite reasonable but it may take me a bit to get back to this, I'm going to a conference for the rest of the week and am likely to be quite busy. If I have a chance I'll try to fix the PR. (But I didn't want to leave you hanging if it took me until the weekend) |
|
I think that is fine. take your time! you found the bug and the fix! |
Numpy attempted to release a feature in 1.14.0, numpy/numpy#6053 which was then reverted in 1.14.1 with numpy/numpy#10411 And then was finally released in 1.16 by numpy/numpy#12447 This also makes a minor enhancement to determines which numpy function should be used at import time instead of run time. The function name was also then updated from _make_sliced_dtype_np_ge_14 to _make_sliced_dtype_np_ge_16 as thats the primary version the feature was released in
bdbc76b to
527d97f
Compare
|
@TomAugspurger this PR looks good to me. Sorry I didn't notice the changes were made as requested. |
|
Thanks @detrout, sorry I missed this earlier. |
|
No worries. I'd felt the discussion implied the patches were good enough and I'd already shipped this fix and the one for #4352 in Debian. Glad to have been able to help. |
Numpy attempted to release a feature in 1.14.0, numpy/numpy#6053 which was then reverted in 1.14.1 with numpy/numpy#10411 And then was finally released in 1.16 by numpy/numpy#12447 This also makes a minor enhancement to determines which numpy function should be used at import time instead of run time. The function name was also then updated from _make_sliced_dtype_np_ge_14 to _make_sliced_dtype_np_ge_16 as thats the primary version the feature was released in
Numpy attempted to release a feature in 1.14.0, but rolled it
back because it caused too many problems. After fixing issues, they
rereleased it in 1.16.0.
This also makes a minor enhancement to determines which numpy function
should be used at import time instead of run time.
7 tests failed with numpy 1.16. They pass with this patch
flake8 daskcc @hmaarrfk