dask.compute traverses python collections#1975
Merged
jcrist merged 1 commit intodask:masterfrom Feb 10, 2017
Merged
Conversation
Previously the top-level function ``dask.compute`` would pass through all non-dask objects. We now wrap all python collections in ``dask.delayed``, allowing ``compute`` to handle builtin python collections containing dask objects. Fixes dask#1968.
Member
Author
|
Ping @eriknw for review. |
Member
|
Hooray! LGTM. |
jcrist
pushed a commit
to jcrist/dask
that referenced
this pull request
Feb 10, 2017
``dask.delayed.compute`` was removed in dask#1975, and was made a simple alias to ``dask.base.compute``. This deprecates the function found here, and redirects users to import from elsewhere. ``dask.delayed.do`` was renamed to ``dask.delayed.delayed`` in dask#1085, making ``dask.delayed.do`` a simple alias. This PR deprecates that alias. Users can always import ``dask.delayed`` as an alias if needed: ``` from dask import delayed as do ```
jcrist
added a commit
to jcrist/dask
that referenced
this pull request
Feb 10, 2017
``dask.delayed.compute`` was removed in dask#1975, and was made a simple alias to ``dask.base.compute``. This deprecates the function found here, and redirects users to import from elsewhere. ``dask.delayed.do`` was renamed to ``dask.delayed.delayed`` in dask#1085, making ``dask.delayed.do`` a simple alias. This PR deprecates that alias. Users can always import ``dask.delayed`` as an alias if needed: ``` from dask import delayed as do ```
mrocklin
pushed a commit
that referenced
this pull request
Feb 12, 2017
``dask.delayed.compute`` was removed in #1975, and was made a simple alias to ``dask.base.compute``. This deprecates the function found here, and redirects users to import from elsewhere. ``dask.delayed.do`` was renamed to ``dask.delayed.delayed`` in #1085, making ``dask.delayed.do`` a simple alias. This PR deprecates that alias. Users can always import ``dask.delayed`` as an alias if needed: ``` from dask import delayed as do ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the top-level function
dask.computewould pass throughall non-dask objects. We now wrap all python collections in
dask.delayed, allowingcomputeto handle builtin pythoncollections containing dask objects. Fixes #1968.