Increase coverage; lower codecov threshold to pass#12214
Increase coverage; lower codecov threshold to pass#12214crusaderky merged 1 commit intodask:mainfrom
Conversation
| env: | ||
| PARALLEL: "true" | ||
| COVERAGE: "true" | ||
| HDF5_USE_FILE_LOCKING: "FALSE" |
There was a problem hiding this comment.
I found these confusing, as it was unclear what actually used them - and in fact, somebody before me DID get confused. I moved them down to the relevant task.
| id: import_tests | ||
| env: | ||
| ARRAYEXPR: ${{ matrix.array-expr }} |
There was a problem hiding this comment.
These did nothing
| env: | ||
| COVERAGE: "true" | ||
| PARALLEL: "true" | ||
| UPSTREAM_DEV: 1 | ||
|
|
There was a problem hiding this comment.
Changed
pytest dask --cov=dask
with
pytest dask --cov
as the former was occasionally starting to track coverage after imports, thus causing the almost totality of __init__.py files to be treated as a coverage miss.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 0 files - 11 0 suites - 11 0s ⏱️ - 3h 29m 40s Results for commit a888dfe. ± Comparison against base commit 1e27392. ♻️ This comment has been updated with latest results. |
| try: | ||
| return module.__version__ | ||
| except AttributeError as e: | ||
| raise ImportError(f"Can't determine version for {module.__name__}") from e |
There was a problem hiding this comment.
psycopg2 is used by neither dask nor distributed AFAICT.
c87a944 to
44cf520
Compare
44cf520 to
a888dfe
Compare
_array_expr_enabled()#12217 (up from 87%).This makes new PRs green as long as they don't reduce coverage further.