Skip to content

Review _array_expr_enabled()#12217

Merged
crusaderky merged 1 commit intodask:mainfrom
crusaderky:array-expr-enabled
Jan 6, 2026
Merged

Review _array_expr_enabled()#12217
crusaderky merged 1 commit intodask:mainfrom
crusaderky:array-expr-enabled

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Jan 1, 2026

  • Add test coverage for _array_expr_enabled
  • Fix bug that would suppress a warning if the array expr flag is flipped in the dask config after dask is imported
  • Add hard failure if someone accidentally writes "false" as a string in the YAML config (which would quietly evaluate as true)

Comment on lines -23 to -27
"The 'array.query-planning' config is now set to "
f"{use_array_expr}, but query planning is already "
f"{'enabled' if ARRAY_EXPR_ENABLED else 'disabled'}. "
"The query-planning config can only be changed before "
"`dask.array` is first imported!"
Copy link
Copy Markdown
Collaborator Author

@crusaderky crusaderky Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could never happen, as nothing was writing to ARRAY_EXPR_ENABLED.

@crusaderky crusaderky marked this pull request as ready for review January 1, 2026 16:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 1, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 97de0f3. ± Comparison against base commit 8d2cc26.

♻️ This comment has been updated with latest results.

@crusaderky
Copy link
Copy Markdown
Collaborator Author

RTD failure seems like a transient glitch, unrelated to this PR.

@crusaderky crusaderky merged commit e357a32 into dask:main Jan 6, 2026
27 checks passed
@crusaderky crusaderky deleted the array-expr-enabled branch January 6, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants