Skip to content

Upstream compat#12165

Merged
jacobtomlinson merged 1 commit intodask:mainfrom
TomAugspurger:tom/ci-upstream-fixes
Nov 21, 2025
Merged

Upstream compat#12165
jacobtomlinson merged 1 commit intodask:mainfrom
TomAugspurger:tom/ci-upstream-fixes

Conversation

@TomAugspurger
Copy link
Copy Markdown
Member

Closes #12139

- xfail docstring check for np.log
- remove pandas 3.x special cases
@dcherian
Copy link
Copy Markdown
Collaborator

do we know what the ufunc failure is?

@TomAugspurger
Copy link
Copy Markdown
Member Author

In [1]: import inspect

In [2]: import numpy as np

In [3]: inspect.signature(np.log).parameters
Out[3]: mappingproxy({'args': <Parameter "*args">, 'kwargs': <Parameter "**kwargs">})

so just *args, **kwargs rather than the actual function names, so the docstring validation fails.

Skimming numpy/numpy#30095 that seemed to be the desired / accepted output.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±0        9 suites  ±0   3h 13m 6s ⏱️ + 2m 25s
 18 154 tests ±0   16 939 ✅ ±0   1 215 💤 ±0  0 ❌ ±0 
162 614 runs  ±0  150 519 ✅  - 1  12 095 💤 +1  0 ❌ ±0 

Results for commit 0448274. ± Comparison against base commit e6ea356.

@jacobtomlinson jacobtomlinson merged commit d420d62 into dask:main Nov 21, 2025
24 of 25 checks passed
TomAugspurger added a commit to TomAugspurger/dask that referenced this pull request Nov 21, 2025
upstream CI failure at https://github.com/dask/dask/actions/runs/19578257113/job/56069330863#step:6:37016

I missed these in dask#12165. And we can improve the skip / xfail slightly,
since it's only the final assertion that fails.
TomAugspurger added a commit to TomAugspurger/dask that referenced this pull request Nov 21, 2025
upstream CI failure at https://github.com/dask/dask/actions/runs/19578257113/job/56069330863#step:6:37016

I missed these in dask#12165. And we can improve the skip / xfail slightly,
since it's only the final assertion that fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️ Upstream CI failed ⚠️

3 participants